Skip to content

GDB pretty-printers#8556

Merged
myrrc merged 1 commit into
developfrom
myrrc/gdb-pretty-printers
Jun 24, 2026
Merged

GDB pretty-printers#8556
myrrc merged 1 commit into
developfrom
myrrc/gdb-pretty-printers

Conversation

@myrrc

@myrrc myrrc commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

GDB pretty-printers for ArrayRef, Array<T>, Id,
and Arc<dyn T> like Arc<dyn ArrayPlugin>

@myrrc myrrc requested a review from a team June 23, 2026 15:47
@myrrc myrrc added the changelog/skip Do not list PR in the changelog label Jun 23, 2026
@myrrc myrrc enabled auto-merge (squash) June 23, 2026 15:47
@myrrc myrrc force-pushed the myrrc/gdb-pretty-printers branch from f65fb0c to 27e1662 Compare June 23, 2026 15:49
@codspeed-hq

codspeed-hq Bot commented Jun 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 1579 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation slice_empty_vortex 310 ns 368.3 ns -15.84%
Simulation encode_varbin[(1000, 8)] 141.1 µs 156.8 µs -10.04%
Simulation chunked_bool_canonical_into[(1000, 10)] 27 µs 16.2 µs +66.33%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%
Simulation eq_i64_constant 319 µs 289.2 µs +10.31%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/gdb-pretty-printers (022fc8f) with develop (1118a20)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc myrrc force-pushed the myrrc/gdb-pretty-printers branch from 27e1662 to 75542b0 Compare June 23, 2026 15:54
@AdamGS

AdamGS commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

can it be in scripts/? I think the root of the repo is already very wide.

@myrrc myrrc requested a review from AdamGS June 23, 2026 16:03
@myrrc myrrc force-pushed the myrrc/gdb-pretty-printers branch from 75542b0 to 44f92c5 Compare June 24, 2026 11:02
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc force-pushed the myrrc/gdb-pretty-printers branch from 44f92c5 to 022fc8f Compare June 24, 2026 11:03
@myrrc myrrc merged commit f41dc23 into develop Jun 24, 2026
74 checks passed
@myrrc myrrc deleted the myrrc/gdb-pretty-printers branch June 24, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants