Skip to content

net (12/12): Activate summary defaults and retire heavy broadcasts - #748

Merged
Patrick W. Healy (phealy) merged 3 commits into
phealy/lightweight-status-thin-clusterfrom
phealy/lightweight-status-remove-matrix
Sep 23, 2026
Merged

Patrick W. Healy (phealy) merged 3 commits into
phealy/lightweight-status-thin-clusterfrom
phealy/lightweight-status-remove-matrix

Conversation

@phealy

@phealy Patrick W. Healy (phealy) commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Consolidated lightweight-status stack: 12/12

Based on #788. This existing draft PR is reused for the user-approved consolidation, replacing unnecessarily fragmented PRs rather than creating another set.

Scope

Remove controller connectivity matrix and full-detail broadcast history, enable summary defaults, finish operations/configuration/architecture/troubleshooting docs including both independent CLI fixes, and preserve the exact root AGENTS.md approval-policy update.

Original work represented: #748, #790, #792, #793, #795. Cross-cutting originals may also be represented by adjacent functional layers.

Size

+498 / -830 = 1,328 non-generated changed lines, measured against the immediate parent. Generated changes: 0 lines, excluded from the approved 2,000-line ceiling. About 1,000 is a guideline, not a requirement to split coherent functionality.

Validation

  • Scoped make fmt across all changed Go packages (tmp/layer12-fmt.log, tmp/final-cli-fix-fmt.log, tmp/final-info-fix-fmt.log)
  • Final relevant Go suites (tmp/final-tests.log, tmp/final-cli-fix-tests.log, tmp/final-info-fix-tests.log)
  • Complete relevant race suite passes on rerun (tmp/final-race-rerun.log) and after each CLI fix integration (tmp/final-cli-fix-race.log, tmp/final-info-fix-race.log)
  • Controller, node, and kubectl binary builds
  • Final 24 frontend unit tests, tsc, Vite production build, actual Chromium regression (tmp/final-frontend-tests.log, tmp/final-frontend-build.log, tmp/final-browser.log); frontend unchanged by CLI integration
  • Final source-target Go suites/race and all three binary builds (tmp/final-allocation-fix-tests.log, tmp/final-allocation-fix-race.log)

The final stack preserves the validated implementation and all three CLI corrections exactly; its only additional tracked difference is the requested AGENTS.md approval/size policy. No PR is merged into main.

Approved 12-PR draft stack

Base: #745. Each PR targets its preceding layer.

#746 -> #812 -> #760 -> #762 -> #755 -> #757 -> #774 -> #764 -> #766 -> #767 -> #788 -> #748

Validation caveat: TestDetailWebSocketCommandAndResponse intermittently reported EOF under race instrumentation; the full relevant race suite passed on rerun without source changes. No data race was reported.

This was referenced Sep 16, 2026
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-remove-matrix branch from d6a64b0 to 71e7587 Compare September 22, 2026 17:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Final review comments remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

Activates summary-only network status publication, retires heavy connectivity broadcasts, and updates related documentation and lifecycle handling.

Changes:

  • Enables summary defaults in code, tests, and rendered configuration.
  • Removes connectivity-matrix generation and detailed broadcast history.
  • Updates operational, configuration, troubleshooting, and architecture documentation.
File Summary
internal/​net/​config/​status_detail_test.go Updates default-mode tests.
internal/​net/​config/​runtime_config.go Sets summary as the default mode.
docs/​net/​troubleshooting.md Adds summary and diagnostic guidance.
docs/​net/​operations.md Documents explicit diagnostics and operations.
docs/​net/​configuration.md Updates runtime configuration guidance.
docs/​net/​architecture.md Describes lightweight status architecture.
deploy/​net/​01-configmap.yaml.tmpl Enables summary publication by default.
cmd/​unbounded-net-node/​status_publication_test.go Tests summary publication defaults.
cmd/​unbounded-net-node/​status_detail_config_test.go Updates configuration expectations.
cmd/​unbounded-net-controller/​websocket.go Retires heavy broadcasts.
cmd/​unbounded-net-controller/​websocket_retention_test.go Tests summary-only retention and shutdown cleanup.
cmd/​unbounded-net-controller/​status_types.go Removes connectivity-matrix types and fields.
cmd/​unbounded-net-controller/​server.go Uses cancellable server context for background loops.
cmd/​unbounded-net-controller/​memory_bench_test.go Removes obsolete matrix benchmarks.
cmd/​unbounded-net-controller/​matrix_memory_test.go Removes obsolete matrix tests.
cmd/​unbounded-net-controller/​cluster_status.go Removes matrix construction.
cmd/​unbounded-net-controller/​cluster_status_test.go Removes matrix test coverage.
AGENTS.md Adds branch and PR approval policy.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/net/configuration.md
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-remove-matrix branch from 71e7587 to de3ac46 Compare September 22, 2026 17:32
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-remove-matrix branch from de3ac46 to f8d79db Compare September 22, 2026 17:58
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-remove-matrix branch from f8d79db to c17ca9c Compare September 22, 2026 18:03
@phealy
Patrick W. Healy (phealy) marked this pull request as ready for review September 22, 2026 18:06
@phealy
Patrick W. Healy (phealy) requested a review from a team September 22, 2026 18:06
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-remove-matrix branch from c17ca9c to 2ed8c7c Compare September 22, 2026 19:06
@cchildress
Cameron Childress (cchildress) force-pushed the phealy/lightweight-status-remove-matrix branch from 2ed8c7c to 279b6ec Compare September 22, 2026 19:39
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-remove-matrix branch 3 times, most recently from 9bea8e2 to 4bf6cd6 Compare September 23, 2026 16:03
Comment thread AGENTS.md Outdated
…il broadcasts

Includes the approved local-branch and PR publication policy.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d2243398-6c36-4c3d-969e-7ed7bfb5b459
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d2243398-6c36-4c3d-969e-7ed7bfb5b459
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d2243398-6c36-4c3d-969e-7ed7bfb5b459
@phealy
Patrick W. Healy (phealy) added this pull request to the merge queue Sep 23, 2026
An error occurred while trying to automatically change base from phealy/lightweight-status-thin-cluster to phealy/lightweight-status-cli-transport September 23, 2026 17:34
Merged via the queue into main with commit 5467b9a Sep 23, 2026
31 checks passed
@phealy
Patrick W. Healy (phealy) deleted the phealy/lightweight-status-remove-matrix branch September 23, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants