net (10/12): Migrate CLI summaries, diagnostics and current node info

[Patrick W. Healy (phealy)]

Consolidated lightweight-status stack: 10/12

Based on #766. This existing draft PR is reused for the user-approved consolidation, replacing unnecessarily fragmented PRs rather than creating another set.

Scope

Complete CLI summary list/watch, explicit named-node show/refresh, authenticated aggregated diagnostic transport, polling, correlation, and expiry. Folds code/tests from independent fixes 1643e7d49723173eedb84b89eea997a248ecb7d3 and 55c62ff8d60d9cdb01188524d59f1da767d39501: controller status-json preserves raw summary fields/unknown metadata and projects legacy nodes without diagnostic arrays; node show INFO uses current overview health/metadata without changing raw diagnostic content or TTL. Both fixes' documentation belongs to layer 12. Includes final decoder allocation fix 31878a7c5b08c151a26e119ec399467a7ed916c7, which prevents summary metadata from retaining the full legacy diagnostic object.

Original work represented: #767, #768, #769, #785, #795. Cross-cutting originals may also be represented by adjacent functional layers.

Size

+1,790 / -172 = 1,962 non-generated changed lines, measured against the immediate parent. Generated changes: 0 lines, excluded from the approved 2,000-line ceiling. About 1,000 is a guideline, not a requirement to split coherent functionality.

Validation

• Scoped make fmt (tmp/layer10-fmt.log, tmp/layer10-cli-fix-fmt.log, tmp/layer10-info-fix-fmt.log)
• go test ./cmd/kubectl-unbounded/app/net (tmp/layer10-net-tests.log)
• go test -race ./cmd/kubectl-unbounded/app/net after each independent fix integration (tmp/layer10-cli-fix-race.log, tmp/layer10-info-fix-race.log)
• go build -o bin/kubectl-unbounded ./cmd/kubectl-unbounded
• Final decoder fix scoped make fmt and CLI race tests (tmp/layer10-allocation-fix-fmt.log, tmp/layer10-allocation-fix-race.log)

The final stack preserves the validated implementation and all three CLI corrections exactly; its only additional tracked difference is the requested AGENTS.md approval/size policy. No PR is merged into main.

Approved 12-PR draft stack

Base: #745. Each PR targets its preceding layer.

#746 -> #812 -> #760 -> #762 -> #755 -> #757 -> #774 -> #764 -> #766 -> #767 -> #788 -> #748

Validation caveat: broader CLI install tests require rendered operator manifests absent from the isolated worktree. The changed net CLI package tests/race suite and complete plugin build pass.

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved critical transport/watch failures and moderate summary rendering, delta, and retry issues remain.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 · 2

Open (4)

• Direct status errors incorrectly bypass port-forward fallback · New
• New watch clients can miss the initial full summary · New
• Delta overlay cannot clear omitted fields · New
• Legacy full summaries do not update sequence state · New

What changed in this PR

Migrates the net CLI to lightweight summaries for list/watch and adds authenticated named-node diagnostic retrieval with legacy compatibility.

Changes:

• Adds summary decoding, polling, delta merging, and legacy projection.
• Adds detail polling, expiry handling, and aggregated transport.
• Updates status JSON compatibility and expands CLI/controller tests.

File	Review summary
cmd/​kubectl-unbounded/​app/​net/​watch.go	Summary watch and delta processing. Critical (1 vote): initial subscriptions can remain blank without a full summary. Moderate: preserve cleared delta fields (2 votes), copy legacy sequence numbers (3 votes), and keep transient polling/retry failures non-fatal (1 vote each, three findings).
cmd/​kubectl-unbounded/​app/​net/​summary_types.go	Summary metadata models and compatibility adapters; no final comments.
cmd/​kubectl-unbounded/​app/​net/​summary_poll_test.go	Summary compatibility and polling tests; no final comments.
cmd/​kubectl-unbounded/​app/​net/​node.go	Summary list/show integration. Moderate: normalize summary tones for list/watch (1 vote), preserve network fields (1 vote), and align legacy projection status semantics (1 vote).
cmd/​kubectl-unbounded/​app/​net/​node_render.go	Summary-based node rendering. Moderate: normalize controller tones before colorization (1 vote).
cmd/​kubectl-unbounded/​app/​net/​node_detail_command_test.go	Named-node command coverage; no final comments.
cmd/​kubectl-unbounded/​app/​net/​detail_poll_test.go	Diagnostic polling and expiry tests; no final comments.
cmd/​kubectl-unbounded/​app/​net/​detail_client.go	Diagnostic transport. Critical: non-2xx aggregated responses can suppress the port-forward fallback; distinguish unavailable routes from controller failures (2 votes).
cmd/​kubectl-unbounded/​app/​net/​detail_client_test.go	Aggregated transport tests; no final comments.
cmd/​kubectl-unbounded/​app/​net/​controller.go	Summary-preserving status JSON export; no final comments.
cmd/​kubectl-unbounded/​app/​net/​controller_test.go	Controller output compatibility tests; no final comments.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.