Skip to content

net (08/12): Add dashboard summary and expiring diagnostic state - #764

Open
Patrick W. Healy (phealy) wants to merge 2 commits into
phealy/lightweight-status-node-publicationfrom
phealy/lightweight-status-dashboard-contract
Open

Patrick W. Healy (phealy) wants to merge 2 commits into
phealy/lightweight-status-node-publicationfrom
phealy/lightweight-status-dashboard-contract

Conversation

@phealy

@phealy Patrick W. Healy (phealy) commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Consolidated lightweight-status stack: 8/12

Based on #774. This existing draft PR is reused for the user-approved consolidation, replacing unnecessarily fragmented PRs rather than creating another set.

Scope

Final frontend summary projection and diagnostic client state, request cancellation/polling/expiry, hook, metadata/freshness preservation, and browser-safe timer implementation. Actual dialog/browser fixtures remain in layer 9.

Original work represented: #764, #765, #766, #782, #783, #784, #796, #797. Cross-cutting originals may also be represented by adjacent functional layers.

Size

+794 / -1 = 795 non-generated changed lines, measured against the immediate parent. Generated changes: 0 lines, excluded from the approved 2,000-line ceiling. About 1,000 is a guideline, not a requirement to split coherent functionality.

Validation

  • TypeScript tsc --noEmit
  • 17 frontend unit tests (tmp/layer08-tests.log)

The final stack preserves the validated implementation and all three CLI corrections exactly; its only additional tracked difference is the requested AGENTS.md approval/size policy. No PR is merged into main.

Approved 12-PR draft stack

Base: #745. Each PR targets its preceding layer.

#746 -> #812 -> #760 -> #762 -> #755 -> #757 -> #774 -> #764 -> #766 -> #767 -> #788 -> #748

This was referenced Sep 16, 2026
@phealy
Patrick W. Healy (phealy) changed the base branch from phealy/lightweight-status-detail-responses to phealy/lightweight-status-node-publication September 17, 2026 14:48
@phealy
Patrick W. Healy (phealy) added this pull request to stack #813 September 17, 2026 14:59
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-dashboard-contract branch from 0a2adda to 86f1d28 Compare September 17, 2026 21:01
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-dashboard-contract branch from 86f1d28 to 0b9601f Compare September 18, 2026 14:31
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-dashboard-contract branch from 0b9601f to 0ddecc6 Compare September 22, 2026 16:44
@phealy
Patrick W. Healy (phealy) removed this pull request from stack #813 September 22, 2026 16:47
@phealy
Patrick W. Healy (phealy) added this pull request to stack #827 September 22, 2026 16:47
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-dashboard-contract branch from 0ddecc6 to 5adcf1d Compare September 22, 2026 17:09
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-dashboard-contract branch from 5adcf1d to a6a7de5 Compare September 22, 2026 17:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved issues remain in diagnostic expiry handling and summary metadata/projection behavior.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 Medium severity

Open (2)
What changed in this PR

Adds frontend dashboard summary projection and cancellable, expiring node diagnostic state.

Changes:

  • Adds summary projection and delta handling.
  • Adds diagnostic polling, cancellation, expiry, and React hook support.
  • Adds API/types and lifecycle tests.
File Summary
frontend/​tests/​nodeDetails.test.ts Diagnostic lifecycle and expiry tests
frontend/​tests/​clusterSummary.test.ts Summary projection tests
frontend/​src/​types.ts Summary and diagnostic result types
frontend/​src/​state/​nodeDetails.ts Diagnostic lifecycle state
frontend/​src/​state/​clusterSummary.ts Summary projection and delta merging
frontend/​src/​hooks/​useNodeDetails.ts React diagnostic hook
frontend/​src/​api.ts Diagnostic HTTP transport

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread frontend/src/api.ts
Comment thread frontend/src/state/clusterSummary.ts Outdated
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-dashboard-contract branch from a6a7de5 to 5e098dc Compare September 22, 2026 17:32
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-dashboard-contract branch from 5e098dc to dab6d5d Compare September 22, 2026 17:58
@phealy
Patrick W. Healy (phealy) marked this pull request as ready for review September 22, 2026 18:06
@phealy
Patrick W. Healy (phealy) requested a review from a team September 22, 2026 18:06
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-dashboard-contract branch from dab6d5d to 9acac96 Compare September 22, 2026 19:06
@cchildress
Cameron Childress (cchildress) force-pushed the phealy/lightweight-status-dashboard-contract branch from 9acac96 to 67dd001 Compare September 22, 2026 19:39
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-dashboard-contract branch from 67dd001 to fe5f9b2 Compare September 22, 2026 20:43
…equests

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d2243398-6c36-4c3d-969e-7ed7bfb5b459
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d2243398-6c36-4c3d-969e-7ed7bfb5b459
@phealy
Patrick W. Healy (phealy) force-pushed the phealy/lightweight-status-dashboard-contract branch from fe5f9b2 to e2c35c6 Compare September 22, 2026 21:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants