Skip to content

Add MAC address vital to host details page#42773

Merged
rachaelshaw merged 5 commits intomainfrom
add-mac-address-vital
Apr 2, 2026
Merged

Add MAC address vital to host details page#42773
rachaelshaw merged 5 commits intomainfrom
add-mac-address-vital

Conversation

@kilo-code-bot
Copy link
Copy Markdown
Contributor

@kilo-code-bot kilo-code-bot bot commented Mar 31, 2026

Summary

  • Adds a new "MAC address" vital to the host details page, displaying primary_mac from the host API response
  • Follows the same rendering pattern as existing vitals (Private IP address, Public IP address, etc.) using DataSet + TooltipTruncatedText
  • Scoped to the same host types that show IP addresses (excludes iOS/iPadOS and Android hosts, matching the behavior in the Manage Hosts table)

Changes

  • frontend/pages/hosts/details/cards/Vitals/Vitals.tsx — Added MAC address vital entry within the existing !isIosOrIpadosHost && !isAndroidHost conditional block

Built for mikermcneil by Kilo for Slack

Display the host's primary MAC address (primary_mac) as a new vital
on the individual host details page, alongside existing vitals like
IP address, OS, and hardware model. The MAC address is shown for the
same host types that display IP addresses (excludes iOS/iPadOS and
Android hosts).
@kilo-code-bot kilo-code-bot bot requested a review from a team as a code owner March 31, 2026 21:24
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.82%. Comparing base (baa4634) to head (f8d5685).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../hosts/details/HostDetailsPage/HostDetailsPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #42773    +/-   ##
========================================
  Coverage   66.82%   66.82%            
========================================
  Files        2544     2544            
  Lines      204231   204232     +1     
  Branches     9274     9159   -115     
========================================
+ Hits       136474   136475     +1     
  Misses      55405    55405            
  Partials    12352    12352            
Flag Coverage Δ
frontend 54.81% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@noahtalerman noahtalerman marked this pull request as draft March 31, 2026 21:29
Co-authored-by: Rachael Shaw <r@rachael.wtf>
Co-authored-by: Rachael Shaw <r@rachael.wtf>
@rachaelshaw rachaelshaw marked this pull request as ready for review April 2, 2026 00:48
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@rachaelshaw rachaelshaw merged commit 1caf3e2 into main Apr 2, 2026
6 of 7 checks passed
@rachaelshaw rachaelshaw deleted the add-mac-address-vital branch April 2, 2026 01:02
kilo-code-bot bot added a commit that referenced this pull request Apr 2, 2026
Add primary_mac to HOST_VITALS_DATA constant and display MAC address
in the Vitals card on the host details page.

Subset of changes from #42773.
kilo-code-bot bot added a commit that referenced this pull request Apr 2, 2026
Cherry-pick Vitals.tsx and constants.tsx changes from PR #42773.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants