[Patrick W. Healy (phealy)]

Consolidated lightweight-status stack: 11/12

Based on #767. This existing draft PR is reused for the user-approved consolidation, replacing unnecessarily fragmented PRs rather than creating another set.

Scope

Cluster overview retention and summary-only pulls, unified legacy per-node reads, expiring viewer detail writes and lifecycle observers. Obsolete per-node broadcast subscription calls are removed with their owner; routine legacy full broadcasts retire in this layer so clients receive summary snapshots and deltas only.

Original work represented: #788, #789, #791. Cross-cutting originals may also be represented by adjacent functional layers.

Size

+1,202 / -283 = 1,485 non-generated changed lines, measured against the immediate parent. Generated changes: 0 lines, excluded from the approved 2,000-line ceiling. About 1,000 is a guideline, not a requirement to split coherent functionality.

Validation

• Scoped make fmt with serialized shared linter lock (tmp/layer11-fmt.log)
• go test ./cmd/unbounded-net-controller (tmp/layer11-tests.log)
• go test ./cmd/unbounded-net-controller ./cmd/kubectl-unbounded/app/net after each CLI restack (tmp/layer11-cli-fix-tests.log, tmp/layer11-info-fix-tests.log)
• Controller and CLI tests after final decoder restack (tmp/layer11-allocation-fix-tests.log)

The final stack preserves the validated implementation and all three CLI corrections exactly; its only additional tracked difference is the requested AGENTS.md approval/size policy. No PR is merged into main.

Approved 12-PR draft stack

Base: #745. Each PR targets its preceding layer.

#746 -> #812 -> #760 -> #762 -> #755 -> #757 -> #774 -> #764 -> #766 -> #767 -> #788 -> #748

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved compatibility, freshness, validation, and lifecycle issues remain.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

• Preserve full node details for legacy status clients · New

What changed in this PR

Unifies controller status reads around summary caching and a shared expiring detail lifecycle.

Changes:

• Adds summary-only cluster pulls and overview retention.
• Routes legacy and WebSocket detail requests through the shared request manager.
• Adds lifecycle, expiry, cancellation, and retention coverage.

File	Description
cmd/​unbounded-net-controller/​ws_summary_test.go	Updates WebSocket subscription tests.
cmd/​unbounded-net-controller/​websocket.go	Removes automatic detail broadcasts and updates client lifecycle handling.
cmd/​unbounded-net-controller/​websocket_details.go	Adds TTL-aware detail watching; lifecycle updates and queued expiry handling need changes (moderate).
cmd/​unbounded-net-controller/​websocket_details_test.go	Tests detail expiry and observer cleanup.
cmd/​unbounded-net-controller/​server.go	Enables thin storage and summary responses.
cmd/​unbounded-net-controller/​server_routes_test.go	Updates legacy route tests.
cmd/​unbounded-net-controller/​node_status.go	Adds thin-cache lifecycle and generic fetching.
cmd/​unbounded-net-controller/​node_overview.go	Fetches and validates summaries; omitted diagnostic fields need presence validation (moderate).
cmd/​unbounded-net-controller/​node_legacy.go	Binds detail lifecycle and startup safeguards.
cmd/​unbounded-net-controller/​node_legacy_test.go	Tests cache lifecycle behavior.
cmd/​unbounded-net-controller/​detail_wait.go	Adds metadata-based waiting for legacy reads.
cmd/​unbounded-net-controller/​detail_wait_test.go	Tests shared legacy requests.
cmd/​unbounded-net-controller/​detail_requests.go	Adds update notifications and expiry handling.
cmd/​unbounded-net-controller/​detail_legacy.go	Invalidates requests on node replacement.
cmd/​unbounded-net-controller/​detail_legacy_test.go	Tests replacement cancellation.
cmd/​unbounded-net-controller/​detail_api.go	Routes legacy reads through the detail manager; cached pushes need refreshed receipt timestamps (moderate).
cmd/​unbounded-net-controller/​cluster_status.go	Uses summary-only background pulls.
cmd/​unbounded-net-controller/​cluster_status_cache.go	Retains overview metadata; normalization currently removes details needed by legacy clients (critical).
cmd/​unbounded-net-controller/​cluster_retention_test.go	Tests retention and summary pulls.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.