feat favorites infrastructure#1980
Open
Mbeaulne wants to merge 1 commit into03-12-dashboard_and_betafrom
Open
Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
8 tasks
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2d82f99 to
2aba91b
Compare
This was referenced Mar 23, 2026
bbf3171 to
b589aa7
Compare
2aba91b to
25ff8b2
Compare
Collaborator
Author
|
Reviewer note: Clean, stable PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Added a new
useFavoritesReact hook that provides functionality for managing user favorites in localStorage. The hook supports adding, removing, and toggling favorite items (pipelines and runs), with automatic synchronization across browser tabs usinguseSyncExternalStore. Includes comprehensive test coverage with 124 test cases covering all functionality including duplicate prevention, cross-tab synchronization, and type-specific item handling.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
useFavoriteshook in a React componentaddFavorite(item)removeFavorite(type, id)toggleFavorite(item)isFavorite(type, id)correctly identifies favorite statusAdditional Comments
The hook uses typed storage for persistence and implements caching to ensure stable references for
useSyncExternalStore. It properly handles different item types (pipeline/run) with the same ID as separate entities.