Skip to content

add favourites to new dashboard#1997

Open
Mbeaulne wants to merge 1 commit into03-24-feat_dashboard_latoutfrom
03-24-add_favourites_to_new_dashboard
Open

add favourites to new dashboard#1997
Mbeaulne wants to merge 1 commit into03-24-feat_dashboard_latoutfrom
03-24-add_favourites_to_new_dashboard

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Mar 24, 2026

Description

Added a new FavoritesSection component that displays user favorites with search and pagination functionality. The component shows favorite pipelines and runs as clickable chips with different styling, includes a search input to filter by name or ID, and supports pagination for large lists. Connected this component to the dashboard favorites route, replacing the placeholder "Coming Soon" page.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the dashboard favorites page
  2. Verify the favorites section displays correctly when no favorites exist
  3. Add some favorite pipelines and runs using the star functionality
  4. Test the search functionality by filtering favorites by name or ID
  5. Verify pagination works correctly when there are more than 10 favorites
  6. Test clicking on favorite chips navigates to the correct pipeline or run
  7. Test removing favorites using the X button on each chip

Additional Comments

The component integrates with the existing useFavorites hook and uses consistent UI components from the design system. Pipeline favorites are styled with violet colors while run favorites use emerald colors for visual distinction.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-24-add_favourites_to_new_dashboard/df0767f`

@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 77dc4aa to df0767f Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne mentioned this pull request Mar 27, 2026
8 tasks
@Mbeaulne
Copy link
Copy Markdown
Collaborator Author

Reviewer note: FavoritesSection.tsx re-added here is identical to the version deleted in #1996 — it is deleted again one PR later in #1998 when the design switches from chips to cards.

DashboardFavoritesView.tsx introduced here as a 5-line shell is completely rewritten in #1998. You can treat this PR as a brief stepping stone — the final favorites implementation is in #1998.

@Mbeaulne Mbeaulne marked this pull request as ready for review March 30, 2026 18:25
@Mbeaulne Mbeaulne requested a review from a team as a code owner March 30, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant