Skip to content

update favourite and recent cards#2001

Open
Mbeaulne wants to merge 1 commit into03-24-updates_revently_viewedfrom
03-24-update_favourite_and_recent_cards
Open

update favourite and recent cards#2001
Mbeaulne wants to merge 1 commit into03-24-updates_revently_viewedfrom
03-24-update_favourite_and_recent_cards

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Mar 24, 2026

Description

Replaced programmatic navigation with Link components in dashboard favorite and recently viewed cards. Changed the type indicators from simple icon/text combinations to pill-style badges with rounded backgrounds. Updated card styling to use consistent shadow effects and neutral colors instead of type-specific color schemes.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the dashboard
  2. Verify that favorite cards are clickable and navigate correctly
  3. Verify that recently viewed cards are clickable and navigate correctly
  4. Test that the remove favorite button works without triggering navigation
  5. Confirm that type pills display correctly for both pipelines and runs
  6. Check that hover effects work properly on the cards

Additional Comments

The Link component provides better accessibility and browser behavior (right-click to open in new tab, etc.) compared to programmatic navigation. The pill-style type indicators provide better visual hierarchy and the unified card styling creates a more consistent interface.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-24-update_favourite_and_recent_cards/ae28aeb`

@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 6dcffa7 to 4dabee9 Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 091ad6b to 89f86e1 Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 4dabee9 to 7c59fd6 Compare March 27, 2026 13:52
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 89f86e1 to 50aadd0 Compare March 27, 2026 13:52
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 7c59fd6 to 6059b23 Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch 2 times, most recently from 2b7baf9 to 878220c Compare March 27, 2026 14:07
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch 2 times, most recently from 1a4aed7 to dfef4db Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 7982636 to ea60d9f Compare March 27, 2026 14:16
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from dfef4db to 0ef8ac0 Compare March 27, 2026 14:16
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from ea60d9f to ae6a6cc Compare March 27, 2026 14:25
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 0ef8ac0 to b6838bc Compare March 27, 2026 14:25
@Mbeaulne Mbeaulne mentioned this pull request Mar 27, 2026
3 tasks
@Mbeaulne
Copy link
Copy Markdown
Collaborator Author

Reviewer note: This PR fixes navigation in both DashboardFavoritesView and DashboardRecentlyViewedView — changing from imperative useNavigate to declarative <Link> for correct browser behavior (right-click to open in new tab, etc.). Both views are stable after this PR.

@Mbeaulne Mbeaulne marked this pull request as ready for review March 30, 2026 18:26
@Mbeaulne Mbeaulne requested a review from a team as a code owner March 30, 2026 18:26
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from b6838bc to 1d68541 Compare April 1, 2026 17:49
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from ae6a6cc to 07359a9 Compare April 1, 2026 17:49
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 1d68541 to b274d0f Compare April 1, 2026 18:34
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 07359a9 to 775a9e7 Compare April 1, 2026 18:34
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from b274d0f to 75ee2c0 Compare April 1, 2026 18:37
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch 2 times, most recently from 5a757b9 to fda9a1b Compare April 1, 2026 18:42
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 75ee2c0 to 7b3cda1 Compare April 1, 2026 18:42
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from fda9a1b to c9e84ec Compare April 2, 2026 16:35
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch 2 times, most recently from ba9600e to 6793af6 Compare April 2, 2026 16:41
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch 2 times, most recently from 54e27d2 to 7246b53 Compare April 2, 2026 16:53
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 6793af6 to 0b84fce Compare April 2, 2026 16:53
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 7246b53 to 7a5a472 Compare April 2, 2026 16:59
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 0b84fce to 227ddc0 Compare April 2, 2026 16:59
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 227ddc0 to ae28aeb Compare April 2, 2026 19:19
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 7a5a472 to aa16ae5 Compare April 2, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant