Skip to content

moves app footer#2010

Open
Mbeaulne wants to merge 1 commit into03-24-add_new_section_to_the_side_barfrom
03-25-moves_app_footer
Open

moves app footer#2010
Mbeaulne wants to merge 1 commit into03-24-add_new_section_to_the_side_barfrom
03-25-moves_app_footer

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Mar 25, 2026

Description

This pull request improves the dashboard layout and user experience with several key changes:

  • Dashboard Layout Redesign: Converted the dashboard from a horizontal layout to a full-height sidebar layout with independent scrolling areas
  • Enhanced Sidebar: Added footer links (About, Give feedback, Privacy policy) and version information display in the sidebar
  • Conditional Footer: Modified the root layout to hide the app footer on dashboard pages to prevent layout conflicts
  • RunRow Component Cleanup: Replaced the Paragraph component with a native span element, added proper text color styling, and set a fixed row height

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the dashboard pages and verify the new sidebar layout displays correctly
  2. Test scrolling behavior in both the sidebar and main content areas
  3. Verify that footer links in the sidebar open correctly in new tabs
  4. Check that the app footer is hidden on dashboard pages but visible on other pages
  5. Confirm that run rows in the pipeline section display properly with the updated styling

Additional Comments

The layout changes create a more professional dashboard experience with better space utilization and improved navigation. The sidebar now includes helpful footer links and version information while maintaining clean separation between navigation and content areas.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-25-moves_app_footer/5d1c576`

@Mbeaulne Mbeaulne mentioned this pull request Mar 25, 2026
8 tasks
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from 7d089d6 to 87e9bd5 Compare March 25, 2026 19:52
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from 4e1b9ee to aeb6fa8 Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch 3 times, most recently from e5dbbd0 to b427379 Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from ad26745 to b2e8ad6 Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from b427379 to d1c9f97 Compare March 27, 2026 14:07
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch 2 times, most recently from 81a314c to d8285d7 Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from d1c9f97 to cff4b8c Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from d8285d7 to df32b4a Compare March 27, 2026 14:16
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from cff4b8c to 651d4c3 Compare March 27, 2026 14:16
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from df32b4a to bed7079 Compare March 27, 2026 14:25
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from 651d4c3 to 4d64ee2 Compare March 27, 2026 14:25
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from bed7079 to 7d99126 Compare March 27, 2026 14:29
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from 4d64ee2 to 26b463a Compare March 27, 2026 14:29
@Mbeaulne Mbeaulne mentioned this pull request Mar 27, 2026
8 tasks
@Mbeaulne
Copy link
Copy Markdown
Collaborator Author

Reviewer note: This PR finalizes the overall dashboard chrome — full-height two-column layout with independent scroll areas, and suppression of the global AppFooter on dashboard routes.

DashboardLayout.tsx is modified one more time in #2011 (sidebar item labels and order updated: "My Dashboard" added at top, "My Pipelines"/"All Runs" renamed), but the layout structure itself is stable after this PR.

@Mbeaulne Mbeaulne marked this pull request as ready for review March 30, 2026 18:27
@Mbeaulne Mbeaulne requested a review from a team as a code owner March 30, 2026 18:27
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from 7d99126 to f63d238 Compare April 1, 2026 17:49
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from 26b463a to ec8aa2b Compare April 1, 2026 17:49
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from f63d238 to e779dcf Compare April 1, 2026 18:34
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from ec8aa2b to 022d528 Compare April 1, 2026 18:34
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from e779dcf to c79a7d7 Compare April 1, 2026 18:37
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from 022d528 to 141846c Compare April 1, 2026 18:37
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from 141846c to 5d1c576 Compare April 1, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant