Skip to content

Update design for favourites#1998

Merged
Mbeaulne merged 2 commits intomasterfrom
03-24-update_design_for_favourites
Apr 10, 2026
Merged

Update design for favourites#1998
Mbeaulne merged 2 commits intomasterfrom
03-24-update_design_for_favourites

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Mar 24, 2026 •
edited
Loading

Description

Replaced the simple FavoritesSection component with a comprehensive favorites management interface in the Dashboard. The new implementation includes a searchable grid of favorite items (pipelines and runs) with pagination, individual favorite cards showing type badges and metadata, and the ability to remove favorites directly from the interface.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the Dashboard favorites view
  2. Add some pipelines and runs to favorites using the star functionality
  3. Verify that favorite items appear in a 4-column grid with appropriate type badges (violet for pipelines, emerald for runs)
  4. Test the search functionality by typing in pipeline/run names or IDs
  5. Test pagination by adding more than 16 favorites
  6. Test removing favorites using the X button that appears on hover
  7. Verify navigation works when clicking on favorite cards
  8. Test the empty state when no favorites exist

Additional Comments

The new favorites view provides a much more user-friendly way to manage and navigate favorite items compared to the previous basic section. It includes visual distinction between pipelines and runs, efficient search and pagination, and intuitive removal functionality.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026 •
edited
Loading

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-24-update_design_for_favourites/25fca73`

This was referenced Mar 24, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Mbeaulne Graphite App
Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Mar 24, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 24, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from d40d065 to 82f814c Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from 9b53fca to 496e03f Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 82f814c to 722df94 Compare March 27, 2026 13:52
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch 2 times, most recently from 2253af0 to 8301e19 Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 722df94 to 4746864 Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from 8301e19 to 8ffa88a Compare March 27, 2026 14:07
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 4746864 to 77dc4aa Compare March 27, 2026 14:07
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from 8ffa88a to dc41654 Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 77dc4aa to df0767f Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from dc41654 to 956698b Compare March 27, 2026 14:16
camielvs
camielvs reviewed Apr 9, 2026
View reviewed changes
Comment thread src/routes/Dashboard/DashboardFavoritesView.tsx Outdated
camielvs
camielvs reviewed Apr 9, 2026
View reviewed changes
Comment thread src/routes/Dashboard/DashboardFavoritesView.tsx Outdated
camielvs
camielvs reviewed Apr 9, 2026
View reviewed changes
Comment thread src/routes/Dashboard/DashboardFavoritesView.tsx Outdated
camielvs
camielvs reviewed Apr 9, 2026
View reviewed changes
Comment thread src/routes/Dashboard/DashboardFavoritesView.tsx
camielvs
camielvs reviewed Apr 9, 2026
View reviewed changes
Comment thread src/routes/Dashboard/DashboardFavoritesView.tsx Outdated
camielvs
camielvs reviewed Apr 9, 2026
View reviewed changes
Comment thread src/routes/Dashboard/DashboardFavoritesView.tsx Outdated
@camielvs Graphite App
Copy link
Copy Markdown
Collaborator

camielvs commented Apr 9, 2026

Should favourited runs show their status in some way?

image.png

One of these runs succeeded and the other one failed

@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 099fb90 to fe4405e Compare April 9, 2026 15:54
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch 3 times, most recently from bea185a to 6e0faed Compare April 9, 2026 16:28
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch 2 times, most recently from 5ed937c to 8f27324 Compare April 9, 2026 16:56
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from 6e0faed to 3428c75 Compare April 9, 2026 16:56
@Mbeaulne Graphite App
Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Apr 10, 2026

Im going to push back on the status for now. in order to get the status we will have to fetch each favourite from the server. Until we get bulk endpoints Im going to wait to impliment features like this.

@Mbeaulne Mbeaulne requested a review from camielvs April 10, 2026 18:38
@Mbeaulne Graphite App
Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Apr 10, 2026

as for the hydration, I don't see it. .. I may have fixed it below

@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from d4a089f to e44dc7a Compare April 10, 2026 19:09
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 8f27324 to 249c7a1 Compare April 10, 2026 19:09
@Mbeaulne Graphite App
Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Apr 10, 2026 •
edited
Loading

Merge activity

  • Apr 10, 8:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 10, 9:08 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 10, 9:11 PM UTC: @Mbeaulne merged this pull request with Graphite.

camielvs
camielvs reviewed Apr 10, 2026
View reviewed changes
Comment thread src/routes/Dashboard/DashboardFavoritesView.tsx
const isPipeline = item.type === "pipeline";

return (
<a
Copy link
Copy Markdown
Collaborator

@camielvs camielvs Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Link />?

camielvs
camielvs approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hydration issues appear to be fixed

@Mbeaulne Mbeaulne changed the base branch from 03-24-add_favourites_to_new_dashboard to graphite-base/1998 April 10, 2026 21:03
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1998 to master April 10, 2026 21:07
Mbeaulne and others added 2 commits April 10, 2026 21:08
@Mbeaulne
Update design for favourites
e8bcf3f
@Mbeaulne @claude
address pr feedback
25fca73 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from e44dc7a to 25fca73 Compare April 10, 2026 21:08
@Mbeaulne Mbeaulne merged commit 16e7953 into master Apr 10, 2026
17 checks passed
@Mbeaulne Mbeaulne deleted the 03-24-update_design_for_favourites branch April 10, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morgan-wowk morgan-wowk morgan-wowk approved these changes

@camielvs camielvs camielvs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mbeaulne @camielvs @morgan-wowk